There is a bug in ppc_prep.c?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

There is a bug in ppc_prep.c?

Tero Kaarlela
Hi,

     I just browsed CVS repository and found following from ppc_prep.c:

       

/* Check LE mode */
        if (val & 0x02) {
            printf("Little Endian mode isn't supported (yet ?)\n");
            abort();

   shouldnt this be ie:

/* Check LE mode */
        if (val & 0x02) {
            printf("Switching to Little Endian mode...");
           /* abort(); */


?

Tero Kaarlela
         





_______________________________________________
Qemu-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/qemu-devel
Reply | Threaded
Open this post in threaded view
|

Re: There is a bug in ppc_prep.c?

J. Mayer
On Sun, 2005-05-22 at 22:07 +0300, Tero Kaarlela wrote:

> Hi,
>
>      I just browsed CVS repository and found following from ppc_prep.c:
>
>        
>
> /* Check LE mode */
>         if (val & 0x02) {
>             printf("Little Endian mode isn't supported (yet ?)\n");
>             abort();
>
>    shouldnt this be ie:
>
> /* Check LE mode */
>         if (val & 0x02) {
>             printf("Switching to Little Endian mode...");
>            /* abort(); */
>
>
> ?

This is supposed to be needed for endian mode switch. However, we have
seen with OS/2 that it would be needed to do nothing when this bit is
set, then I'd prefer to do nothing: that only means, imho, that we don't
know what need to be swapped. Then I'd better not have the feature than
do sthing that I know is a bug (ie does not correspond to platform
specification).
Then, I did let this untouched in the repository.

--
J. Mayer <[hidden email]>
Never organized



_______________________________________________
Qemu-devel mailing list
[hidden email]
http://lists.nongnu.org/mailman/listinfo/qemu-devel