[PATCH v2 0/5] MAINTAINERS: Fine adjustment for (mostly mips) content

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 0/5] MAINTAINERS: Fine adjustment for (mostly mips) content

Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

v1->v2:

  - removed patch on new git infrastructure section
  - added a patch that adds two files in Malta section

The goal of this series is to:

  * reduce the amount of "unmainatined" files (not having their
    maintainer in "MAINTAINERS")
  * reduce the amount of nominally maintained files, but unmaintained
    in reality
  * increase the role of non-mips open source participants in
    maintaining and reviewing mips content

I contacted most of the involved persons regarding these changes.
I am asking all to accept new roles, since really there seems to
be no better option than this. Please help QEMU maintainance, and
best wishes to all in future activities and enavours!

I am fine with Philippe and Herve sending direct pull requests from
coresponding areas to Peter.

Aleksandar Markovic (5):
  MAINTAINERS: Add a section on UI translation
  MAINTAINERS: Adjust maintainership for Fulong 2E board
  MAINTAINERS: Adjust maintainership for Malta board
  MAINTAINERS: Adjust maintainership for R4000 systems
  MAINTAINERS: Add two files to Malta section

 MAINTAINERS | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

--
2.7.4


Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/5] MAINTAINERS: Add a section on UI translation

Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

There should be a person who will quickly evaluate new UI
translation, and find a way to update existing ones should
something changes in UI.

Signed-off-by: Aleksandar Markovic <[hidden email]>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 363e72a..fd9ba32 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2714,6 +2714,11 @@ M: Daniel P. Berrange <[hidden email]>
 S: Odd Fixes
 F: scripts/git-submodule.sh
 
+UI translations
+M: Aleksandar Markovic <[hidden email]>
+R: Philippe Mathieu-Daudé <[hidden email]>
+F: po/*.po
+
 Sphinx documentation configuration and build machinery
 M: Peter Maydell <[hidden email]>
 S: Maintained
--
2.7.4


Reply | Threaded
Open this post in threaded view
|

[PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

Aleksandar Markovic
In reply to this post by Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

Change the maintainership for Fulong 2E board to improve its quality.

Signed-off-by: Aleksandar Markovic <[hidden email]>
---
 MAINTAINERS | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fd9ba32..3bf2144 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -976,9 +976,10 @@ S: Maintained
 F: hw/mips/mips_r4k.c
 
 Fulong 2E
-M: Aleksandar Markovic <[hidden email]>
-R: Aleksandar Rikalo <[hidden email]>
-S: Odd Fixes
+M: Philippe Mathieu-Daudé <[hidden email]>
+R: Hervé Poussineau <[hidden email]>
+R: Aleksandar Markovic <[hidden email]>
+S: Maintained
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
 F: hw/pci-host/bonito.c
--
2.7.4


Reply | Threaded
Open this post in threaded view
|

[PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board

Aleksandar Markovic
In reply to this post by Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

Change the maintainership for Malta board to improve its quality.

Acked-by: Aurelien Jarno <[hidden email]>
Signed-off-by: Aleksandar Markovic <[hidden email]>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3bf2144..6afec32 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -955,8 +955,9 @@ F: hw/display/jazz_led.c
 F: hw/dma/rc4030.c
 
 Malta
-M: Aurelien Jarno <[hidden email]>
-R: Aleksandar Rikalo <[hidden email]>
+M: Philippe Mathieu-Daudé <[hidden email]>
+R: Hervé Poussineau <[hidden email]>
+R: Aurelien Jarno <[hidden email]>
 S: Maintained
 F: hw/mips/mips_malta.c
 F: hw/mips/gt64xxx_pci.c
--
2.7.4


Reply | Threaded
Open this post in threaded view
|

[PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Aleksandar Markovic
In reply to this post by Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

Change the maintainership for R4000 systems to improve its quality.

Acked-by: Aurelien Jarno <[hidden email]>
Signed-off-by: Aleksandar Markovic <[hidden email]>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6afec32..ba9ca98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
 F: hw/net/mipsnet.c
 
 R4000
-M: Aurelien Jarno <[hidden email]>
-R: Aleksandar Rikalo <[hidden email]>
+M: Hervé Poussineau <[hidden email]>
+R: Aurelien Jarno <[hidden email]>
+R: Philippe Mathieu-Daudé <[hidden email]>
 S: Maintained
 F: hw/mips/mips_r4k.c
 
--
2.7.4


Reply | Threaded
Open this post in threaded view
|

[PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

Aleksandar Markovic
In reply to this post by Aleksandar Markovic
From: Aleksandar Markovic <[hidden email]>

Add two files that were recently introduced in a refactoring,
that Malta emulation relies on. They are added by this patch
to Malta section, but they are not added to the general MIPS
section, since they are really not MIPS-specific, and there
may be some non-MIPS hardware using them in future.

Signed-off-by: Aleksandar Markovic <[hidden email]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ba9ca98..f8a1646 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -959,8 +959,10 @@ M: Philippe Mathieu-Daudé <[hidden email]>
 R: Hervé Poussineau <[hidden email]>
 R: Aurelien Jarno <[hidden email]>
 S: Maintained
+F: hw/isa/piix4.c
 F: hw/mips/mips_malta.c
 F: hw/mips/gt64xxx_pci.c
+F: include/hw/southbridge/piix.h
 F: tests/acceptance/linux_ssh_mips_malta.py
 
 Mipssim
--
2.7.4


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/5] MAINTAINERS: Add a section on UI translation

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic
Hi Aleksandar,

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <[hidden email]>
>
> There should be a person who will quickly evaluate new UI
> translation, and find a way to update existing ones should
> something changes in UI.

I appreciate your trust, but I'm afraid I know next to nothing about
po/. I don't use QEMU's GUI myself: mostly command line, and via libvirt
from time to time.

These files are about language translations, maybe it is easier to let
them unmaintained and have patches go via the trivial tree?

>
> Signed-off-by: Aleksandar Markovic <[hidden email]>
> ---
>   MAINTAINERS | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 363e72a..fd9ba32 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2714,6 +2714,11 @@ M: Daniel P. Berrange <[hidden email]>
>   S: Odd Fixes
>   F: scripts/git-submodule.sh
>  
> +UI translations
> +M: Aleksandar Markovic <[hidden email]>
> +R: Philippe Mathieu-Daudé <[hidden email]>
> +F: po/*.po
> +
>   Sphinx documentation configuration and build machinery
>   M: Peter Maydell <[hidden email]>
>   S: Maintained
>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic
Hi Aleksandar,

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <[hidden email]>
>
> Change the maintainership for Fulong 2E board to improve its quality.

IIRC you told me once this board is named Fuloong, and its CPU is a
‎Loongson, both with 2x 'o' :) I have a patch renaming the various
occurrences.

> Signed-off-by: Aleksandar Markovic <[hidden email]>
> ---
>   MAINTAINERS | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fd9ba32..3bf2144 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -976,9 +976,10 @@ S: Maintained
>   F: hw/mips/mips_r4k.c
>  
>   Fulong 2E
> -M: Aleksandar Markovic <[hidden email]>
> -R: Aleksandar Rikalo <[hidden email]>
> -S: Odd Fixes
> +M: Philippe Mathieu-Daudé <[hidden email]>

I am happy to keep the Fuloong working, but this will be on my personal
(hobbyist) time. This area is not a priority for my employer, so I'll
use my personal email: [hidden email].

The original author is active on the Linux kernel, let ask him if he'd
be OK to keep an eye on his work.

Huacai, would you agree to be listed as a reviewer on the Fuloong
related QEMU files? You don't have to worry about the generic QEMU code
plate (like keeping API up to date) I'll manage that, but I'd like to
have you listed to assert the hardware is properly modeled.

You would appear as:
R: Huacai Chen <[hidden email]>

> +R: Hervé Poussineau <[hidden email]>

I don't think Hervé is interested by this board, he has not modified the
code.

> +R: Aleksandar Markovic <[hidden email]>
> +S: Maintained

Let keep it as "Odd Fixes" :)

   Odd Fixes:   It has a maintainer but they don't have
                time to do much other than throw the odd
                patch in.

>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c
>   F: hw/pci-host/bonito.c
>

So the patch would be:

-- 8< --
  Fulong 2E
-M: Aleksandar Markovic <[hidden email]>
-R: Aleksandar Rikalo <[hidden email]>
+M: Philippe Mathieu-Daudé <[hidden email]>
+R: Aleksandar Markovic <[hidden email]>
+R: Huacai Chen <[hidden email]>
  S: Odd Fixes
  F: hw/mips/mips_fulong2e.c
  F: hw/isa/vt82c686.c
---

But let's wait to see what Huacai Chen thinks of it, before posting it.

Thanks for taking care of those changes!

Phil.


Reply | Threaded
Open this post in threaded view
|

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

Aleksandar Markovic-4
Hi, Philippe,

> From: Philippe Mathieu-Daudé <[hidden email]>
>
> Hi Aleksandar,
>
> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <[hidden email]>
> >
> > Change the maintainership for Fulong 2E board to improve its quality.
>
> IIRC you told me once this board is named Fuloong, and its CPU is a
‎> Loongson, both with 2x 'o' :) I have a patch renaming the various
> occurrences.
>

I still think that the oficial name is "Fuloong 2E", however, it is
shortened to "Fulong 2E" quite often in communication, and, it seems,
sometimes even in various docs/app notes etc.

Can perhaps Huacai Chen enlighten us regarding the right spelling?

> > Signed-off-by: Aleksandar Markovic <[hidden email]>
> > ---
> >   MAINTAINERS | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index fd9ba32..3bf2144 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -976,9 +976,10 @@ S: Maintained
> >   F: hw/mips/mips_r4k.c
> >
> >   Fulong 2E
> > -M: Aleksandar Markovic <[hidden email]>
> > -R: Aleksandar Rikalo <[hidden email]>
> > -S: Odd Fixes
> > +M: Philippe Mathieu-Daudé <[hidden email]>
>
> I am happy to keep the Fuloong working, but this will be on my personal
> (hobbyist) time. This area is not a priority for my employer, so I'll
> use my personal email: [hidden email].
>

OK.

> The original author is active on the Linux kernel, let ask him if he'd
> be OK to keep an eye on his work.
>
> Huacai, would you agree to be listed as a reviewer on the Fuloong
> related QEMU files? You don't have to worry about the generic QEMU code
> plate (like keeping API up to date) I'll manage that, but I'd like to
> have you listed to assert the hardware is properly modeled.
>
> You would appear as:
> R: Huacai Chen <[hidden email]>
>

That is a great idea!

Please, Chen, get involved, you would be very welcomed, there is a place
for you in QEMU community!


> > +R: Hervé Poussineau <[hidden email]>
>
> I don't think Hervé is interested by this board, he has not modified the
> code.
>
> > +R: Aleksandar Markovic <[hidden email]>
> > +S: Maintained
>
> Let keep it as "Odd Fixes" :)
>

OK.

>    Odd Fixes:   It has a maintainer but they don't have
>                 time to do much other than throw the odd
>                 patch in.
>
> >   F: hw/mips/mips_fulong2e.c
> >   F: hw/isa/vt82c686.c
> >   F: hw/pci-host/bonito.c
> >
>
> So the patch would be:
>
> -- 8< --
>   Fulong 2E
> -M: Aleksandar Markovic <[hidden email]>
> -R: Aleksandar Rikalo <[hidden email]>
> +M: Philippe Mathieu-Daudé <[hidden email]>
> +R: Aleksandar Markovic <[hidden email]>
> +R: Huacai Chen <[hidden email]>
>   S: Odd Fixes
>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c

Plus possible s/Fulong 2E/Fuloong 2E/

> ---
>
> But let's wait to see what Huacai Chen thinks of it, before posting it.
>
> Thanks for taking care of those changes!
>
> Phil.
>
>

Thank you!

Aleksandar
Reply | Threaded
Open this post in threaded view
|

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

chen huacai
Hi, all,

On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic
<[hidden email]> wrote:

>
> Hi, Philippe,
>
> > From: Philippe Mathieu-Daudé <[hidden email]>
> >
> > Hi Aleksandar,
> >
> > On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> > > From: Aleksandar Markovic <[hidden email]>
> > >
> > > Change the maintainership for Fulong 2E board to improve its quality.
> >
> > IIRC you told me once this board is named Fuloong, and its CPU is a
> ‎> Loongson, both with 2x 'o' :) I have a patch renaming the various
> > occurrences.
> >
>
> I still think that the oficial name is "Fuloong 2E", however, it is
> shortened to "Fulong 2E" quite often in communication, and, it seems,
> sometimes even in various docs/app notes etc.
>
> Can perhaps Huacai Chen enlighten us regarding the right spelling?
The right spelling is Fuloong.

>
> > > Signed-off-by: Aleksandar Markovic <[hidden email]>
> > > ---
> > >   MAINTAINERS | 7 ++++---
> > >   1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index fd9ba32..3bf2144 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -976,9 +976,10 @@ S: Maintained
> > >   F: hw/mips/mips_r4k.c
> > >
> > >   Fulong 2E
> > > -M: Aleksandar Markovic <[hidden email]>
> > > -R: Aleksandar Rikalo <[hidden email]>
> > > -S: Odd Fixes
> > > +M: Philippe Mathieu-Daudé <[hidden email]>
> >
> > I am happy to keep the Fuloong working, but this will be on my personal
> > (hobbyist) time. This area is not a priority for my employer, so I'll
> > use my personal email: [hidden email].
> >
>
> OK.
>
> > The original author is active on the Linux kernel, let ask him if he'd
> > be OK to keep an eye on his work.
> >
> > Huacai, would you agree to be listed as a reviewer on the Fuloong
> > related QEMU files? You don't have to worry about the generic QEMU code
> > plate (like keeping API up to date) I'll manage that, but I'd like to
> > have you listed to assert the hardware is properly modeled.
> >
> > You would appear as:
> > R: Huacai Chen <[hidden email]>
> >
>
> That is a great idea!
>
> Please, Chen, get involved, you would be very welcomed, there is a place
> for you in QEMU community!
I'm sorry that I'm busy now, but I think I will do something in QEMU
in the next year.

>
>
> > > +R: Hervé Poussineau <[hidden email]>
> >
> > I don't think Hervé is interested by this board, he has not modified the
> > code.
> >
> > > +R: Aleksandar Markovic <[hidden email]>
> > > +S: Maintained
> >
> > Let keep it as "Odd Fixes" :)
> >
>
> OK.
>
> >    Odd Fixes:   It has a maintainer but they don't have
> >                 time to do much other than throw the odd
> >                 patch in.
> >
> > >   F: hw/mips/mips_fulong2e.c
> > >   F: hw/isa/vt82c686.c
> > >   F: hw/pci-host/bonito.c
> > >
> >
> > So the patch would be:
> >
> > -- 8< --
> >   Fulong 2E
> > -M: Aleksandar Markovic <[hidden email]>
> > -R: Aleksandar Rikalo <[hidden email]>
> > +M: Philippe Mathieu-Daudé <[hidden email]>
> > +R: Aleksandar Markovic <[hidden email]>
> > +R: Huacai Chen <[hidden email]>
> >   S: Odd Fixes
> >   F: hw/mips/mips_fulong2e.c
> >   F: hw/isa/vt82c686.c
>
> Plus possible s/Fulong 2E/Fuloong 2E/
>
> > ---
> >
> > But let's wait to see what Huacai Chen thinks of it, before posting it.
> >
> > Thanks for taking care of those changes!
> >
> > Phil.
> >
> >
>
> Thank you!
>
> Aleksandar
Thanks,

Huacai

Reply | Threaded
Open this post in threaded view
|

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

Philippe Mathieu-Daudé-3
On 11/14/19 2:08 PM, chen huacai wrote:

> Hi, all,
>
> On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic
> <[hidden email]> wrote:
>>
>> Hi, Philippe,
>>
>>> From: Philippe Mathieu-Daudé <[hidden email]>
>>>
>>> Hi Aleksandar,
>>>
>>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
>>>> From: Aleksandar Markovic <[hidden email]>
>>>>
>>>> Change the maintainership for Fulong 2E board to improve its quality.
>>>
>>> IIRC you told me once this board is named Fuloong, and its CPU is a
>> ‎> Loongson, both with 2x 'o' :) I have a patch renaming the various
>>> occurrences.
>>>
>>
>> I still think that the oficial name is "Fuloong 2E", however, it is
>> shortened to "Fulong 2E" quite often in communication, and, it seems,
>> sometimes even in various docs/app notes etc.
>>
>> Can perhaps Huacai Chen enlighten us regarding the right spelling?
> The right spelling is Fuloong.
>
[...]>>> The original author is active on the Linux kernel, let ask him
if he'd

>>> be OK to keep an eye on his work.
>>>
>>> Huacai, would you agree to be listed as a reviewer on the Fuloong
>>> related QEMU files? You don't have to worry about the generic QEMU code
>>> plate (like keeping API up to date) I'll manage that, but I'd like to
>>> have you listed to assert the hardware is properly modeled.
>>>
>>> You would appear as:
>>> R: Huacai Chen <[hidden email]>
>>>
>>
>> That is a great idea!
>>
>> Please, Chen, get involved, you would be very welcomed, there is a place
>> for you in QEMU community!
> I'm sorry that I'm busy now, but I think I will do something in QEMU
> in the next year.

No problem, we'll keep in touch.

>>>> +R: Hervé Poussineau <[hidden email]>
>>>
>>> I don't think Hervé is interested by this board, he has not modified the
>>> code.
>>>
>>>> +R: Aleksandar Markovic <[hidden email]>
>>>> +S: Maintained
>>>
>>> Let keep it as "Odd Fixes" :)
>>>
>>
>> OK.
>>
>>>     Odd Fixes:   It has a maintainer but they don't have
>>>                  time to do much other than throw the odd
>>>                  patch in.
>>>
>>>>    F: hw/mips/mips_fulong2e.c
>>>>    F: hw/isa/vt82c686.c
>>>>    F: hw/pci-host/bonito.c
>>>>
>>>
>>> So the patch would be:
>>>
>>> -- 8< --
>>>    Fulong 2E
>>> -M: Aleksandar Markovic <[hidden email]>
>>> -R: Aleksandar Rikalo <[hidden email]>
>>> +M: Philippe Mathieu-Daudé <[hidden email]>
>>> +R: Aleksandar Markovic <[hidden email]>
>>> +R: Huacai Chen <[hidden email]>
>>>    S: Odd Fixes
>>>    F: hw/mips/mips_fulong2e.c
>>>    F: hw/isa/vt82c686.c
>>
>> Plus possible s/Fulong 2E/Fuloong 2E/

I'd prefer to keep this change for later, with the patch cleaning its
use in the codebase (not that trivial because we need to alias the
machine name to keep backward compatibility).

>>
>>> ---
>>>
>>> But let's wait to see what Huacai Chen thinks of it, before posting it.

Aleksandar, can you stay as co-maintainer?

The patch would be:

-- 8< --
    Fulong 2E
+M: Philippe Mathieu-Daudé <[hidden email]>
  M: Aleksandar Markovic <[hidden email]>
-R: Aleksandar Rikalo <[hidden email]>
    S: Odd Fixes
    F: hw/mips/mips_fulong2e.c
    F: hw/isa/vt82c686.c
---

Either this way, or if you prefer to be listed with a R-tag:
Acked-by: Philippe Mathieu-Daudé <[hidden email]>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic
+Paul Burton

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:

> From: Aleksandar Markovic <[hidden email]>
>
> Change the maintainership for Malta board to improve its quality.
>
> Acked-by: Aurelien Jarno <[hidden email]>
> Signed-off-by: Aleksandar Markovic <[hidden email]>
> ---
>   MAINTAINERS | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3bf2144..6afec32 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -955,8 +955,9 @@ F: hw/display/jazz_led.c
>   F: hw/dma/rc4030.c
>  
>   Malta
> -M: Aurelien Jarno <[hidden email]>
 > +R: Aurelien Jarno <[hidden email]>

Aurelien, do you want to stay co-maintainer with this one?
Else, thanks for staying listed as designated reviewer :)

> -R: Aleksandar Rikalo <[hidden email]>
> +M: Philippe Mathieu-Daudé <[hidden email]>

I'm happy to continue Aurelien work with this board :)
Similarly to the Fuloong board, I mostly use the Malta as a hobby, so
I'll use my personal email.

Paul, do you mind being co-maintainer or at least listed as designated
reviewer here?

> +R: Hervé Poussineau <[hidden email]>

I don't see commits from Hervé with this board, so he is probably not
interested.

>   S: Maintained

Until Paul is interested in co-maintenance, let's change this board
status to 'Odd Fixes'.

>   F: hw/mips/mips_malta.c
>   F: hw/mips/gt64xxx_pci.c


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic
Hi Aleksandar,

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:

> From: Aleksandar Markovic <[hidden email]>
>
> Change the maintainership for R4000 systems to improve its quality.
>
> Acked-by: Aurelien Jarno <[hidden email]>
> Signed-off-by: Aleksandar Markovic <[hidden email]>
> ---
>   MAINTAINERS | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6afec32..ba9ca98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
>   F: hw/net/mipsnet.c
>  
>   R4000
> -M: Aurelien Jarno <[hidden email]>
> -R: Aleksandar Rikalo <[hidden email]>
> +M: Hervé Poussineau <[hidden email]>

Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I
don't think he is interested.

> +R: Aurelien Jarno <[hidden email]>
> +R: Philippe Mathieu-Daudé <[hidden email]>
>   S: Maintained
>   F: hw/mips/mips_r4k.c

Now back to this board, I am having hard time to understand what it
models. IIUC it predates the Malta board, and was trying to model a
board able to run the first MIPS cpu when the port was added in 2005
(see commit 6af0bf9c7c3a).
The Malta board was added 1 year later (commit 5856de800df) and models a
real hardware.

As Aurelien acked to step down maintaining it, it seems the perfect
timing to start its deprecation process. I'll prepare a patch for 5.0
(unless someone is really using it and willing to maintain it).

Regards,

Phil.


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Aleksandar Markovic-5
On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé
<[hidden email]> wrote:

>
> Hi Aleksandar,
>
> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <[hidden email]>
> >
> > Change the maintainership for R4000 systems to improve its quality.
> >
> > Acked-by: Aurelien Jarno <[hidden email]>
> > Signed-off-by: Aleksandar Markovic <[hidden email]>
> > ---
> >   MAINTAINERS | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6afec32..ba9ca98 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
> >   F: hw/net/mipsnet.c
> >
> >   R4000
> > -M: Aurelien Jarno <[hidden email]>
> > -R: Aleksandar Rikalo <[hidden email]>
> > +M: Hervé Poussineau <[hidden email]>
>
> Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I
> don't think he is interested.
>
> > +R: Aurelien Jarno <[hidden email]>
> > +R: Philippe Mathieu-Daudé <[hidden email]>
> >   S: Maintained
> >   F: hw/mips/mips_r4k.c
>
> Now back to this board, I am having hard time to understand what it
> models. IIUC it predates the Malta board, and was trying to model a
> board able to run the first MIPS cpu when the port was added in 2005
> (see commit 6af0bf9c7c3a).
> The Malta board was added 1 year later (commit 5856de800df) and models a
> real hardware.
>
> As Aurelien acked to step down maintaining it, it seems the perfect
> timing to start its deprecation process. I'll prepare a patch for 5.0
> (unless someone is really using it and willing to maintain it).
>

Philippe, hi.

Herve told me a while ago that he does care about R4000 being
supported, as it is closely related to Jazz machines, so please
don't start any deprecation process.

Herve is the most familiar of all of us with R4000, and, for that
reason, my suggestion is to keep the patch as it is. Let me know
if you have any objections.

One alternative approach would be to merge "R4000" and
"Jazz" sections. But, let's leave it for future as an option,
if nobody objects.

Yours,
Aleksandar

> Regards,
>
> Phil.
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Philippe Mathieu-Daudé-3
On 11/22/19 3:14 PM, Aleksandar Markovic wrote:

> On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé
> <[hidden email]> wrote:
>>
>> Hi Aleksandar,
>>
>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
>>> From: Aleksandar Markovic <[hidden email]>
>>>
>>> Change the maintainership for R4000 systems to improve its quality.
>>>
>>> Acked-by: Aurelien Jarno <[hidden email]>
>>> Signed-off-by: Aleksandar Markovic <[hidden email]>
>>> ---
>>>    MAINTAINERS | 5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 6afec32..ba9ca98 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
>>>    F: hw/net/mipsnet.c
>>>
>>>    R4000
>>> -M: Aurelien Jarno <[hidden email]>
>>> -R: Aleksandar Rikalo <[hidden email]>
>>> +M: Hervé Poussineau <[hidden email]>
>>
>> Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I
>> don't think he is interested.
>>
>>> +R: Aurelien Jarno <[hidden email]>
>>> +R: Philippe Mathieu-Daudé <[hidden email]>
>>>    S: Maintained
>>>    F: hw/mips/mips_r4k.c
>>
>> Now back to this board, I am having hard time to understand what it
>> models. IIUC it predates the Malta board, and was trying to model a
>> board able to run the first MIPS cpu when the port was added in 2005
>> (see commit 6af0bf9c7c3a).
>> The Malta board was added 1 year later (commit 5856de800df) and models a
>> real hardware.
>>
>> As Aurelien acked to step down maintaining it, it seems the perfect
>> timing to start its deprecation process. I'll prepare a patch for 5.0
>> (unless someone is really using it and willing to maintain it).
>>
>
> Philippe, hi.
>
> Herve told me a while ago that he does care about R4000 being
> supported, as it is closely related to Jazz machines, so please
> don't start any deprecation process.

I think what Hervé meant to say is he cares about the R4000 CPU
(implementing the MIPSIII architecture). The Magnum and Pica boards
indeed use a R4000 CPU. I also personally care about this CPU, and don't
want it to disappear.

Here we are talking about the some Frankenstein board. QEMU aims to
model real hardware, with the exception of the 'Virt' boards that have
specifications. Here I can't find any. I am not against Hervé
maintaining this file if he has some interest in it, but I think there
are confusion and we are talking about 2 different topics.

> Herve is the most familiar of all of us with R4000, and, for that
> reason, my suggestion is to keep the patch as it is. Let me know
> if you have any objections.
>
> One alternative approach would be to merge "R4000" and
> "Jazz" sections. But, let's leave it for future as an option,
> if nobody objects.
>
> Yours,
> Aleksandar
>
>> Regards,
>>
>> Phil.
>>
>>
>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic
On 11/13/19 2:47 PM, Aleksandar Markovic wrote:

> From: Aleksandar Markovic <[hidden email]>
>
> Add two files that were recently introduced in a refactoring,
> that Malta emulation relies on. They are added by this patch
> to Malta section, but they are not added to the general MIPS
> section, since they are really not MIPS-specific, and there
> may be some non-MIPS hardware using them in future.
>
> Signed-off-by: Aleksandar Markovic <[hidden email]>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ba9ca98..f8a1646 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -959,8 +959,10 @@ M: Philippe Mathieu-Daudé <[hidden email]>
>   R: Hervé Poussineau <[hidden email]>
>   R: Aurelien Jarno <[hidden email]>
>   S: Maintained
> +F: hw/isa/piix4.c

Maybe:

    F: hw/*/piix4.c

Or also add:

    F: hw/acpi/piix4.c

>   F: hw/mips/mips_malta.c
>   F: hw/mips/gt64xxx_pci.c
> +F: include/hw/southbridge/piix.h
>   F: tests/acceptance/linux_ssh_mips_malta.py
>  
>   Mipssim
>

Reviewed-by: Philippe Mathieu-Daudé <[hidden email]>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

Aleksandar Markovic-5
On Fri, Nov 22, 2019 at 9:28 PM Philippe Mathieu-Daudé
<[hidden email]> wrote:

>
> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <[hidden email]>
> >
> > Add two files that were recently introduced in a refactoring,
> > that Malta emulation relies on. They are added by this patch
> > to Malta section, but they are not added to the general MIPS
> > section, since they are really not MIPS-specific, and there
> > may be some non-MIPS hardware using them in future.
> >
> > Signed-off-by: Aleksandar Markovic <[hidden email]>
> > ---
> >   MAINTAINERS | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ba9ca98..f8a1646 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -959,8 +959,10 @@ M: Philippe Mathieu-Daudé <[hidden email]>
> >   R: Hervé Poussineau <[hidden email]>
> >   R: Aurelien Jarno <[hidden email]>
> >   S: Maintained
> > +F: hw/isa/piix4.c
>
> Maybe:
>
>     F: hw/*/piix4.c
>
> Or also add:
>
>     F: hw/acpi/piix4.c
>

Philippe, are you sure? hw/acpi/piix4.c is used in PC, not in Malta, no?

> >   F: hw/mips/mips_malta.c
> >   F: hw/mips/gt64xxx_pci.c
> > +F: include/hw/southbridge/piix.h
> >   F: tests/acceptance/linux_ssh_mips_malta.py
> >
> >   Mipssim
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <[hidden email]>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

Hervé Poussineau
In reply to this post by Philippe Mathieu-Daudé-3
Le 22/11/2019 à 16:29, Philippe Mathieu-Daudé a écrit :

> On 11/22/19 3:14 PM, Aleksandar Markovic wrote:
>> On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé
>> <[hidden email]> wrote:
>>>
>>> Hi Aleksandar,
>>>
>>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
>>>> From: Aleksandar Markovic <[hidden email]>
>>>>
>>>> Change the maintainership for R4000 systems to improve its quality.
>>>>
>>>> Acked-by: Aurelien Jarno <[hidden email]>
>>>> Signed-off-by: Aleksandar Markovic <[hidden email]>
>>>> ---
>>>>    MAINTAINERS | 5 +++--
>>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 6afec32..ba9ca98 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
>>>>    F: hw/net/mipsnet.c
>>>>
>>>>    R4000
>>>> -M: Aurelien Jarno <[hidden email]>
>>>> -R: Aleksandar Rikalo <[hidden email]>
>>>> +M: Hervé Poussineau <[hidden email]>
>>>
>>> Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I
>>> don't think he is interested.
>>>
>>>> +R: Aurelien Jarno <[hidden email]>
>>>> +R: Philippe Mathieu-Daudé <[hidden email]>
>>>>    S: Maintained
>>>>    F: hw/mips/mips_r4k.c
>>>
>>> Now back to this board, I am having hard time to understand what it
>>> models. IIUC it predates the Malta board, and was trying to model a
>>> board able to run the first MIPS cpu when the port was added in 2005
>>> (see commit 6af0bf9c7c3a).
>>> The Malta board was added 1 year later (commit 5856de800df) and models a
>>> real hardware.
>>>
>>> As Aurelien acked to step down maintaining it, it seems the perfect
>>> timing to start its deprecation process. I'll prepare a patch for 5.0
>>> (unless someone is really using it and willing to maintain it).
>>>
>>
>> Philippe, hi.
>>
>> Herve told me a while ago that he does care about R4000 being
>> supported, as it is closely related to Jazz machines, so please
>> don't start any deprecation process.
>
> I think what Hervé meant to say is he cares about the R4000 CPU (implementing the MIPSIII architecture). The Magnum and Pica boards indeed use a R4000 CPU. I also personally care about this CPU, and
> don't want it to disappear.
>
> Here we are talking about the some Frankenstein board. QEMU aims to model real hardware, with the exception of the 'Virt' boards that have specifications. Here I can't find any. I am not against Hervé
> maintaining this file if he has some interest in it, but I think there are confusion and we are talking about 2 different topics.

Philippe is right.
I care about Magnum/PICA boards (which have a R4000 cpu).
I don't care about this the mips_r4k.c machine, and I think that deprecating mips_r4k.c machine is the right thing to do.

>
>> Herve is the most familiar of all of us with R4000, and, for that
>> reason, my suggestion is to keep the patch as it is. Let me know
>> if you have any objections.
>>
>> One alternative approach would be to merge "R4000" and
>> "Jazz" sections. But, let's leave it for future as an option,
>> if nobody objects.

Jazz and mips_r4k machines have mostly nothing in common, except using a R4000 CPU and an ISA bus.

Regards,

Hervé

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

Philippe Mathieu-Daudé-3
In reply to this post by Aleksandar Markovic-5
On 11/22/19 9:37 PM, Aleksandar Markovic wrote:

> On Fri, Nov 22, 2019 at 9:28 PM Philippe Mathieu-Daudé
> <[hidden email]> wrote:
>>
>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
>>> From: Aleksandar Markovic <[hidden email]>
>>>
>>> Add two files that were recently introduced in a refactoring,
>>> that Malta emulation relies on. They are added by this patch
>>> to Malta section, but they are not added to the general MIPS
>>> section, since they are really not MIPS-specific, and there
>>> may be some non-MIPS hardware using them in future.
>>>
>>> Signed-off-by: Aleksandar Markovic <[hidden email]>
>>> ---
>>>    MAINTAINERS | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index ba9ca98..f8a1646 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -959,8 +959,10 @@ M: Philippe Mathieu-Daudé <[hidden email]>
>>>    R: Hervé Poussineau <[hidden email]>
>>>    R: Aurelien Jarno <[hidden email]>
>>>    S: Maintained
>>> +F: hw/isa/piix4.c
>>
>> Maybe:
>>
>>      F: hw/*/piix4.c
>>
>> Or also add:
>>
>>      F: hw/acpi/piix4.c
>>
>
> Philippe, are you sure? hw/acpi/piix4.c is used in PC, not in Malta, no?

It is instantiated via:

   mips_malta_init -> piix4_create -> piix4_pm_init

The ACPI block is part of the PIIX4 chipset and should be mapped
unconditionally.


The Malta indeed uses a PIIX4, which is a PIIX3 extended.

The PC uses a Frankenstein PIIX3 with ACPI from PIIX4... I suppose
because it started with a PIIX3, then we wanted power saving features
but it was too late to switch to the PIIX4, so we abused of the fact
than these blocks are exposed internally as PCI devices, so we can
overload a PIIX3.

See https://www.mail-archive.com/qemu-devel@.../msg601512.html


FYI I have a patch ready removing the 'if smbus' check in piix4_create().

>>>    F: hw/mips/mips_malta.c
>>>    F: hw/mips/gt64xxx_pci.c
>>> +F: include/hw/southbridge/piix.h
>>>    F: tests/acceptance/linux_ssh_mips_malta.py
>>>
>>>    Mipssim
>>>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <[hidden email]>
>>
>>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 5/5] MAINTAINERS: Add two files to Malta section

Aleksandar Markovic-5


On Saturday, November 23, 2019, Philippe Mathieu-Daudé <[hidden email]> wrote:
On 11/22/19 9:37 PM, Aleksandar Markovic wrote:
On Fri, Nov 22, 2019 at 9:28 PM Philippe Mathieu-Daudé
<[hidden email]> wrote:

On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
From: Aleksandar Markovic <[hidden email]>

Add two files that were recently introduced in a refactoring,
that Malta emulation relies on. They are added by this patch
to Malta section, but they are not added to the general MIPS
section, since they are really not MIPS-specific, and there
may be some non-MIPS hardware using them in future.

Signed-off-by: Aleksandar Markovic <[hidden email]>
---
   MAINTAINERS | 2 ++
   1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ba9ca98..f8a1646 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -959,8 +959,10 @@ M: Philippe Mathieu-Daudé <[hidden email]>
   R: Hervé Poussineau <[hidden email]>
   R: Aurelien Jarno <[hidden email]>
   S: Maintained
+F: hw/isa/piix4.c

Maybe:

     F: hw/*/piix4.c

Or also add:

     F: hw/acpi/piix4.c


Philippe, are you sure? hw/acpi/piix4.c is used in PC, not in Malta, no?

It is instantiated via:

  mips_malta_init -> piix4_create -> piix4_pm_init

The ACPI block is part of the PIIX4 chipset and should be mapped unconditionally.


Philippe, OK, sorry I failed to notice this detail. It just looked odd to me that ACPI and MIPS could be connected, but stranger things happen. I am going to add

F: hw/acpi/piix4.c

in the next version of this series. Should any change happen in the future, I leave it to you to update the file list, of course.

Have a great sunny weekend!

Aleksandar

 

The Malta indeed uses a PIIX4, which is a PIIX3 extended.

The PC uses a Frankenstein PIIX3 with ACPI from PIIX4... I suppose because it started with a PIIX3, then we wanted power saving features but it was too late to switch to the PIIX4, so we abused of the fact than these blocks are exposed internally as PCI devices, so we can overload a PIIX3.

See https://www.mail-archive.com/qemu-devel@.../msg601512.html


FYI I have a patch ready removing the 'if smbus' check in piix4_create().

   F: hw/mips/mips_malta.c
   F: hw/mips/gt64xxx_pci.c
+F: include/hw/southbridge/piix.h
   F: tests/acceptance/linux_ssh_mips_malta.py

   Mipssim


Reviewed-by: Philippe Mathieu-Daudé <[hidden email]>



12